[Openmp-commits] [PATCH] D25504: Fixes a memory leak related to task dependencies (patch from Alex Duran)

Jonas Hahnfeld via Openmp-commits openmp-commits at lists.llvm.org
Thu Oct 20 23:21:15 PDT 2016


Hahnfeld added a comment.

In https://reviews.llvm.org/D25504#568429, @Eugene.Zelenko wrote:

> Please run Clang-format over changed code.


My last information is that the reformatting is still outstanding which means that `clang-format` will currently lead to inconsistencies.



================
Comment at: runtime/src/kmp_taskdeps.cpp:122-148
+void __kmp_dephash_free_entries(kmp_info_t *thread, kmp_dephash_t *h) {
+  for (size_t i = 0; i < h->size; i++) {
+    if (h->buckets[i]) {
+      kmp_dephash_entry_t *next;
+      for (kmp_dephash_entry_t *entry = h->buckets[i]; entry; entry = next) {
+        next = entry->next_in_bucket;
+        __kmp_depnode_list_free(thread, entry->last_ins);
----------------
For example these two functions will be heavily reformatted for no actual benefit


Repository:
  rL LLVM

https://reviews.llvm.org/D25504





More information about the Openmp-commits mailing list