[Openmp-commits] [PATCH] D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs
Hal Finkel via Openmp-commits
openmp-commits at lists.llvm.org
Thu Oct 13 02:26:45 PDT 2016
hfinkel added a comment.
In https://reviews.llvm.org/D13072#256043, @dberlin wrote:
> In https://reviews.llvm.org/D13072#252598, @jcownie wrote:
> > It generally looks fine to me.
> > My one concern is over the licence in the header file. It looks like a BSD-ish licence, but it's not the same as either of the licences which apply to the rest of the code ( http://llvm.org/svn/llvm-project/openmp/trunk/LICENSE.txt ). (Of course, IANAL).
> Urf. Speaking as a lawyer, in practice, this doesn't matter.
> However, we should fix all of these, not just the Google one.
> The BSD license in that project should not be the license we use. We have generally not given credit to specific groups *in the license*, as that LICENSE does, but instead elsewhere. The license should be the same license we use for runtime libraries elsewhere (which is not even BSD, but MIT).
> I'll start a thread about this.
@dberlin , how do we move forward here? Having the OpenMP runtime library work well with TSan is important.
More information about the Openmp-commits