[Openmp-commits] [PATCH] D19878: Use C++11 atomics for ticket locks implementation

Fri May 13 13:56:13 PDT 2016

pawosm01 added a comment.

In http://reviews.llvm.org/D19878#429947, @hbae wrote:

> - I don't think it is necessary to introduce a new member "self" since std::atomic should be working fine with pointer types. Is there any specific reason for separating the original variable " initialized" into "initialized" and "self"?

I don't remember, looks redundant for me now.

> - I don't know why KMP_FSYNC* calls were removed in the new code. It may not be meaningful in many cases, but it is not dead code as far as I know.

Unfortunately, I don't see what you're pointing at. Can you quote some example?

Repository:
  rL LLVM

http://reviews.llvm.org/D19878