[Openmp-commits] [PATCH] D19878: Use C++11 atomics for ticket locks implementation

Hansang Bae via Openmp-commits openmp-commits at lists.llvm.org
Fri May 13 13:19:00 PDT 2016


hbae added a comment.

- I don't think it is necessary to introduce a new member "self" since std::atomic should be working fine with pointer types. Is there any specific reason for separating the original variable " initialized" into "initialized" and "self"?
- I don't know why KMP_FSYNC* calls were removed in the new code. It may not be meaningful in many cases, but it is not dead code as far as I know.


Repository:
  rL LLVM

http://reviews.llvm.org/D19878





More information about the Openmp-commits mailing list