[Openmp-commits] [openmp] r264786 - Fix comment in kmp_wait_release.h

Jonathan Peyton via Openmp-commits openmp-commits at lists.llvm.org
Tue Mar 29 14:08:29 PDT 2016


Author: jlpeyton
Date: Tue Mar 29 16:08:29 2016
New Revision: 264786

URL: http://llvm.org/viewvc/llvm-project?rev=264786&view=rev
Log:
Fix comment in kmp_wait_release.h

Removed reference to "ref ct" in a comment, as ref_ct no longer exists. Also
moved the comment to where the task_team is about to be tested if NULL.

Modified:
    openmp/trunk/runtime/src/kmp_wait_release.h

Modified: openmp/trunk/runtime/src/kmp_wait_release.h
URL: http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/src/kmp_wait_release.h?rev=264786&r1=264785&r2=264786&view=diff
==============================================================================
--- openmp/trunk/runtime/src/kmp_wait_release.h (original)
+++ openmp/trunk/runtime/src/kmp_wait_release.h Tue Mar 29 16:08:29 2016
@@ -167,17 +167,15 @@ __kmp_wait_template(kmp_info_t *this_thr
     // Main wait spin loop
     while (flag->notdone_check()) {
         int in_pool;
-
-        /* If the task team is NULL, it means one of things:
-           1) A newly-created thread is first being released by __kmp_fork_barrier(), and
-              its task team has not been set up yet.
-           2) All tasks have been executed to completion, this thread has decremented the task
-              team's ref ct and possibly deallocated it, and should no longer reference it.
-           3) Tasking is off for this region.  This could be because we are in a serialized region
-              (perhaps the outer one), or else tasking was manually disabled (KMP_TASKING=0).  */
         kmp_task_team_t * task_team = NULL;
         if (__kmp_tasking_mode != tskm_immediate_exec) {
             task_team = this_thr->th.th_task_team;
+            /* If the thread's task team pointer is NULL, it means one of 3 things:
+	       1) A newly-created thread is first being released by __kmp_fork_barrier(), and
+	          its task team has not been set up yet.
+	       2) All tasks have been executed to completion.
+	       3) Tasking is off for this region.  This could be because we are in a serialized region
+	          (perhaps the outer one), or else tasking was manually disabled (KMP_TASKING=0).  */
             if (task_team != NULL) {
                 if (TCR_SYNC_4(task_team->tt.tt_active)) {
                     if (KMP_TASKING_ENABLED(task_team))




More information about the Openmp-commits mailing list