[Openmp-commits] [PATCH] D21332: Remove unused wait/release code.

[Yonghong Yan via Openmp-commits]

Thank you Andrey and Terry. I am not familiar how C++ template is
implemented and assuming they are compiler tricks. Even that, could there
be (noticeable) overhead introduced for using C++ and template to the
runtime after refactoring?

Yonghong

On Tue, Jun 14, 2016 at 4:01 PM, Wilmarth, Terry L <
terry.l.wilmarth at intel.com> wrote:

> No, we just use a different mechanism now for all the other flag types
> (template classes in kmp_wait_release.h).  Eventually 64 bit flags might be
> always be able to use the same mechanism (and some of them already do), but
> it requires more code refactoring for cases that don’t currently use the
> flag templates.
>
>
>
> *From:* Yonghong Yan [mailto:yanyh15 at gmail.com]
> *Sent:* Tuesday, June 14, 2016 2:44 PM
> *To:* reviews+D21332+public+a169a41bbeffbe44 at reviews.llvm.org; Peyton,
> Jonathan L <jonathan.l.peyton at intel.com>
> *Cc:* Wilmarth, Terry L <terry.l.wilmarth at intel.com>; Bae, Hansang <
> hansang.bae at intel.com>; openmp-commits at lists.llvm.org
> *Subject:* Re: [Openmp-commits] [PATCH] D21332: Remove unused
> wait/release code.
>
>
>
>
>
> Does that mean 32-bit support is being removed? how about those *_4 and
> *_4u ones, e.g. __kmpc_dispatch_fini_4u? I know those __kmpc are compiler
> interfaces.
>
>
> If no 32-bit, how about also __kmp_wait_64 to __kmp_wait ?
>
>
>
>
>
> On Tue, Jun 14, 2016 at 3:22 PM, Jonathan Peyton via Openmp-commits <
> openmp-commits at lists.llvm.org> wrote:
>
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL272697: Remove unused wait/release code. (authored by
> jlpeyton).
>
> Changed prior to commit:
>   http://reviews.llvm.org/D21332?vs=60714&id=60721#toc
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D21332
>
> Files:
>   openmp/trunk/runtime/src/dllexports
>   openmp/trunk/runtime/src/exports_so.txt
>   openmp/trunk/runtime/src/kmp.h
>   openmp/trunk/runtime/src/kmp_wait_release.cpp
>
>
> _______________________________________________
> Openmp-commits mailing list
> Openmp-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-commits
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20160614/68043f6b/attachment-0001.html>