<div dir="ltr">Thank you Andrey and Terry. I am not familiar how C++ template is implemented and assuming they are compiler tricks. Even that, could there be (noticeable) overhead introduced for using C++ and template to the runtime after refactoring?<div><br></div><div>Yonghong<br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 14, 2016 at 4:01 PM, Wilmarth, Terry L <span dir="ltr"><<a href="mailto:terry.l.wilmarth@intel.com" target="_blank">terry.l.wilmarth@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Gisha",sans-serif;color:#4d7479">No, we just use a different mechanism now for all the other flag types (template classes in kmp_wait_release.h). Eventually 64 bit flags might be always be able
to use the same mechanism (and some of them already do), but it requires more code refactoring for cases that don’t currently use the flag templates.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Gisha",sans-serif;color:#4d7479"><u></u> <u></u></span></p>
<p class="MsoNormal"><a name="m_-4387360461806109913______replyseparator"></a><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Yonghong Yan [mailto:<a href="mailto:yanyh15@gmail.com" target="_blank">yanyh15@gmail.com</a>]
<br>
<b>Sent:</b> Tuesday, June 14, 2016 2:44 PM<span class=""><br>
<b>To:</b> <a href="mailto:reviews%2BD21332%2Bpublic%2Ba169a41bbeffbe44@reviews.llvm.org" target="_blank">reviews+D21332+public+a169a41bbeffbe44@reviews.llvm.org</a>; Peyton, Jonathan L <<a href="mailto:jonathan.l.peyton@intel.com" target="_blank">jonathan.l.peyton@intel.com</a>><br>
</span><b>Cc:</b> Wilmarth, Terry L <<a href="mailto:terry.l.wilmarth@intel.com" target="_blank">terry.l.wilmarth@intel.com</a>>; Bae, Hansang <<a href="mailto:hansang.bae@intel.com" target="_blank">hansang.bae@intel.com</a>>; <a href="mailto:openmp-commits@lists.llvm.org" target="_blank">openmp-commits@lists.llvm.org</a><span class=""><br>
<b>Subject:</b> Re: [Openmp-commits] [PATCH] D21332: Remove unused wait/release code.<u></u><u></u></span></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Does that mean 32-bit support is being removed? how about those *_4 and *_4u ones, e.g. __kmpc_dispatch_fini_4u? I know those __kmpc are compiler interfaces. <u></u><u></u></p>
</div><div><div class="h5">
<div>
<p class="MsoNormal"><br clear="all">
<u></u><u></u></p>
<div>
<div>
<div>
<div>
<p class="MsoNormal">If no 32-bit, how about also __kmp_wait_64 to __kmp_wait ?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Tue, Jun 14, 2016 at 3:22 PM, Jonathan Peyton via Openmp-commits <<a href="mailto:openmp-commits@lists.llvm.org" target="_blank">openmp-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL272697: Remove unused wait/release code. (authored by jlpeyton).<br>
<br>
Changed prior to commit:<br>
<a href="http://reviews.llvm.org/D21332?vs=60714&id=60721#toc" target="_blank">
http://reviews.llvm.org/D21332?vs=60714&id=60721#toc</a><br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D21332" target="_blank">http://reviews.llvm.org/D21332</a><br>
<br>
Files:<br>
openmp/trunk/runtime/src/dllexports<br>
openmp/trunk/runtime/src/exports_so.txt<br>
openmp/trunk/runtime/src/kmp.h<br>
openmp/trunk/runtime/src/kmp_wait_release.cpp<br>
<br>
<br>
_______________________________________________<br>
Openmp-commits mailing list<br>
<a href="mailto:Openmp-commits@lists.llvm.org" target="_blank">Openmp-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-commits</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</div>
</blockquote></div><br></div></div></div>