[Openmp-commits] [PATCH] D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs

[Jonathan Peyton via Openmp-commits]

jlpeyton added a comment.

> Keeping the separate instrumented library, we might define the library as an additional build target, so we build both libraries with a single make step. But I found the latest version of the CMake file very confusing for adding a second library target with only slightly different options.


It's probably confusing because it isn't structured to do that.  It is somewhat modeled after libcxx's CMake which does something similar (compile just a single library) although ours is always shared.  i.e., there is a single, hard-coded add_library(omp SHARED ...) call.  Hence, only one library can be built.  I know compiler-rt has custom CMake AddClangRuntimeLibrary(${libname} ...) functionality  where several slightly different libraries are generated for the compiler.  For instance, when I build llvm/clang on x86 about 40 libclang_rt*.a's are created.  If we need this functionality it will have to be added to the CMake logic.


http://reviews.llvm.org/D13072