[Openmp-commits] [PATCH] D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs

[Joachim Protze via Openmp-commits]

protze.joachim added a comment.

In http://reviews.llvm.org/D13072#252137, @hfinkel wrote:

> > The building will generate a library called libomp_tsan.so.
>
> >  I guess this is not something that we want, so probably it should be removed, but I will leave it for the first review.
>
>
> Why would this not be desirable? What's the alternative?


I see two ways to work around the duplicate build for the two libraries:
We might add weak, empty copies of the annotation functions to the library which would be overwritten by the tsan-rt functions if these are loaded. This would be at the cost of additional function calls for each annotation.

Keeping the separate instrumented library, we might define the library as an additional build target, so we build both libraries with a single make step. But I found the latest version of the CMake file very confusing for adding a second library target with only slightly different options.


http://reviews.llvm.org/D13072