[Openmp-commits] [PATCH] D14027: [OMPT] Windows Support for OMPT

[John Mellor-Crummey via Openmp-commits]

jmellorcrummey added a comment.

One final comment:

I designed ompt-general.c as a source file that could be used by anyone any runtime system to implement OMPT. Before this revision, there was no dependence of this file on anything to do with Intel runtime. This change introduces several KMP defines to this runtime. I would prefer that the names of defines used in this file have the OMPT prefix, e.g. OMPT_WEAK_ATTRIBUTE, OMPT_PSAPI, and OMPT_DEBUG. These defines could be set in ompt-specific.h (which is intended provide details for tailoring OMPT for any particular runtime) as

#define OMPT_WEAK_ATTRIBUTE KMP_WEAK_ATTRIBUTE
#define OMPT_PSAPI KMP_PSAPI
#define OMPT_DEBUG KMP_TRACE


Repository:
  rL LLVM

http://reviews.llvm.org/D14027