[Openmp-commits] [PATCH] D13689: Add OMPT events for API locking

[John Mellor-Crummey via Openmp-commits]

jmellorcrummey added a comment.

In reading this patch over again, I realized that you implemented the OMPT TR2 lock initialization callback rather than the OMPT working draft, which also passes a lock hint and a lock type to the init callback. The OMPT implementation in LLVM OpenMP is evolving with the current version of the OMPT draft. There are features already in the code that aren't in OMPT TR2. Fort that reason, I think you should add the lock hint and lock type parameters.


Repository:
  rL LLVM

http://reviews.llvm.org/D13689