[Openmp-commits] [PATCH] D14746: Add support for ompt_event_task_dependences and ompt_event_task_dependence_pair

[John Mellor-Crummey via Openmp-commits]

jmellorcrummey added a comment.

Overall, the patch looks good. Sorry that it has taken me so long to review it.

A few minor quibbles:

The # if USE_FAST_MEMORY is used to in two places to select between allocation and free routines. I think it would be better to use it in only one place and say

#if USE_FAST_MEMORY
#define KMP_OMPT_DEPS_ALLOC kmp_fast_allocate
#define KMP_OMPT_DEPS_FREE  kmp_fast_free
#else
#define KMP_OMPT_DEPS_ALLOC kmp_thread_malloc
#define KMP_OMPT_DEPS_FREE  kmp_thread_free
#endif

and then use the macros defined above in the OMPT code. Note: in the above definitions, I omitted the leading underscores, which created underlined phrases in the formatting.

The comments in the ompt.h.var files shouldn't say "new task dependences" and "new task dependence pair". It would be better to say "report task dependences" and "report task dependence pair".


http://reviews.llvm.org/D14746