[Openmp-commits] [PATCH] Add new files for OMPT

Olga Malysheva olga.malysheva at intel.com
Thu Apr 16 07:28:49 PDT 2015


================
Comment at: runtime/src/ompt-specific.c:32
@@ +31,3 @@
+#else
+#define NEXT_ID(id_ptr,tid) (__sync_fetch_and_add(id_ptr, 1))
+#endif
----------------
Hahnfeld wrote:
> omalyshe wrote:
> > Can you consider using  KMP_TEST_THEN_INC* macro instead (src/kmp_os.h) to make it working on Windows?
> We have tested the change and everything works as expected (only looking at the macro, there shouldn't be any difference for Unix systems at all: It evaluates to __sync_fetch_and_add)
Yes, for Unix systems KMP_TEST_THEN_INC* macro evaluates to __sync_fetch_and_add but not for Windows. As I understand the OMPT code should work on Windows as well but with __sync_fetch_and_add it couldn't be even compiled.

http://reviews.llvm.org/D8917

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the Openmp-commits mailing list