[Openmp-commits] [PATCH] Add new files for OMPT

[Jonas Hahnfeld]

In http://reviews.llvm.org/D8917#154943, @jlpeyton wrote:

> In http://reviews.llvm.org/D8917#154437, @Hahnfeld wrote:
>
> > I just noticed that there is a CMakeLists.txt in runtime/src/ as well. Is it deprecated?
>
>
> I'm not sure who this belongs to honestly... Can someone else pipe in here?
>
> - Johnny


I can safely remove the file and the build with CMake is still working...
This is probably a relict of the first CMake build system that can still be used with runtime/CMakeLists.txt.old (btw: this gives me an error and doesn't work at all)

Back to OMPT:
Do you want me to post updated revisions? Till now we have only included your feedback as marked in the other comments...


================
Comment at: runtime/src/ompt-internal.h:7
@@ +6,3 @@
+
+#define OMPT_VERSION 1
+
----------------
omalyshe wrote:
> I suggest using "1.0".
The Technical Report expects the version number as unsigned int...

page 19,
>int ompt_initialize(ompt_function_lookup_t lookup, const char *runtime_version, unsigned int ompt_version);

================
Comment at: runtime/src/ompt-specific.c:32
@@ +31,3 @@
+#else
+#define NEXT_ID(id_ptr,tid) (__sync_fetch_and_add(id_ptr, 1))
+#endif
----------------
omalyshe wrote:
> Can you consider using  KMP_TEST_THEN_INC* macro instead (src/kmp_os.h) to make it working on Windows?
We have tested the change and everything works as expected (only looking at the macro, there shouldn't be any difference for Unix systems at all: It evaluates to __sync_fetch_and_add)

http://reviews.llvm.org/D8917

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/