[Mlir-commits] [mlir] [mlir][linalg] Skip rank reduction for unsigned-cast contractions (PR #225993)

[llvmlistbot at llvm.org]

================
@@ -175,6 +175,99 @@ func.func @batch_matmul_to_vecmat(%arg0: memref<1x1x?xf32>, %arg1: memref<1x?x?x
 
 // -----
 
+// linalg.vecmat has no cast attribute (it always uses signed casts), so a
+// matmul with an unsigned cast must not be rank-reduced into it.
----------------
speryt wrote:

Ok, I see your point. What about changing comment to let's say "linalg.vecmat currently has no cast attribute"?

I can create issue and RFC once the current PR will be merged so I'll have something to refer to.

https://github.com/llvm/llvm-project/pull/225993