[Mlir-commits] [mlir] [mlir][linalg] Skip rank reduction for unsigned-cast contractions (PR #225993)

[Federico Bruzzone]

================
@@ -175,6 +175,99 @@ func.func @batch_matmul_to_vecmat(%arg0: memref<1x1x?xf32>, %arg1: memref<1x?x?x
 
 // -----
 
+// linalg.vecmat has no cast attribute (it always uses signed casts), so a
+// matmul with an unsigned cast must not be rank-reduced into it.
----------------
FedericoBruzzone wrote:

I agree! However, I would slightly modify this comment to better clarify this point. 

I think that, in addition to a new eventual issue, it might be worth drafting an RFC on this matter.
However, if there’s no need to implement this support at the moment, we can simply postpone the discussion. But the comment should reflect this fact.

https://github.com/llvm/llvm-project/pull/225993