[Mlir-commits] [flang] [mlir] [mlir] Mark dump() methods with LLVM_DUMP_METHOD (PR #233398)

[Eugene Epshteyn]

================
@@ -38,7 +38,8 @@ struct ElementwiseOpPattern : public OpConversionPattern<Op> {
     if (SPIRVOp::template hasTrait<OpTrait::spirv::UnsignedOp>() &&
         !getElementTypeOrSelf(op.getType()).isIndex() &&
         dstType != op.getType()) {
-      op.dump();
+      op.print(llvm::errs(), OpPrintingFlags().useLocalScope());
+      llvm::errs() << "\n";
----------------
eugeneepshteyn wrote:

nit: same here — the `emitError` below already points at the op, so this print could just be removed (it shows up as a stray line on stderr in arith-to-spirv-unsupported.mlir).

https://github.com/llvm/llvm-project/pull/233398