[Mlir-commits] [flang] [mlir] [mlir] Mark dump() methods with LLVM_DUMP_METHOD (PR #233398)

[Eugene Epshteyn]

================
@@ -87,7 +87,8 @@ static int dumpMLIR() {
     if (!module)
       return 1;
 
-    module->dump();
+    module->print(llvm::errs());
+    llvm::errs() << "\n";
----------------
eugeneepshteyn wrote:

nit: without `useLocalScope()`, a top-level module goes through the top-level printer, which already ends the output with a newline, so the following `llvm::errs() << "\n";` now leaves an extra blank line. Could you drop those explicit newlines here, in the other toyc chapters, and at the `--dump-library-module` site in mlir-transform-opt?

https://github.com/llvm/llvm-project/pull/233398