[Mlir-commits] [mlir] [mlir][vector] Fix mask rank extension for TransferWriteNonPermutationLowering (PR #229852)

[Federico Bruzzone]

================
@@ -47,19 +47,25 @@ static Value extendVectorRank(OpBuilder &builder, Location loc, Value vec,
   return vector::BroadcastOp::create(builder, loc, newVecType, vec);
 }
 
-/// Extend the rank of a vector Value by `addedRanks` by adding inner unit
-/// dimensions.
+/// Extend the rank of a mask Value by adding unit dimensions at the positions
+/// `missingInnerDims` of the result.
----------------
FedericoBruzzone wrote:

[nit] Should we say that `missingInnerDims` is relative to the first written dim, not absolute?

Am I missing something here?

https://github.com/llvm/llvm-project/pull/229852