[Mlir-commits] [mlir] [mlir] Add searchable remark history and query-based links (PR #237762)

[Henrich Lauko]

================
@@ -164,6 +166,13 @@ llvm::remarks::Remark Remark::generateRemark() const {
 // InFlightRemark
 //===----------------------------------------------------------------------===//
 
+InFlightRemark &InFlightRemark::operator<<(const RelatedRemarkQuery &related) {
+  if (remark && owner)
+    for (RemarkId id : owner->findRemarks(related.query))
----------------
xlauko wrote:

findRemarks builds a SmallVector that is used only to iterate. An internal forEachMatch(const RemarkQuery &, llvm::function_ref<void(RemarkId)>) would avoid the allocation, and the public findRemarks could be built on top of it.

https://github.com/llvm/llvm-project/pull/237762