[Mlir-commits] [mlir] [mlir] Add searchable remark history and query-based links (PR #237762)

[Henrich Lauko]

================
@@ -174,6 +183,71 @@ InFlightRemark::~InFlightRemark() {
 // Remark Engine
 //===----------------------------------------------------------------------===//
 
+struct RemarkEngine::RemarkHistory {
+  struct Entry {
+    RemarkId id;
+    RemarkKind kind;
+    Location location;
+    std::string name, category, subCategory, function;
----------------
xlauko wrote:

Each entry stores four std::strings, although names and categories repeat heavily. Interning them in an llvm::UniqueStringSaver inside RemarkHistory, under the existing mutex, would make entries StringRefs and remove the per-report allocations.

https://github.com/llvm/llvm-project/pull/237762