[Mlir-commits] [mlir] [MLIR][ArithToSPIRV] Guard NoSignedWrap/NoUnsignedWrap behind extension/version check (PR #189061)

[Igor Wodiany]

IgWod wrote:

Option 4: Lower the flags and attach `SPV_KHR_no_integer_wrap_decoration` to the module, using similar logic to #188743.

The downside is that it may force the extension on a target that doesn't support it. If that's the problem; what about hybrid of option 2 and 4? Have an option that allows to either drop the flags if not supported or lower them and have a SPIR-V dialect to infer the extension?

But I'd also be happy with option 1 if that's the consensus.

https://github.com/llvm/llvm-project/pull/189061