[Mlir-commits] [mlir] [MLIR][LLVM] Add DILocAttr for debug locations (PR #186146)

[Christian Ulmann]

https://github.com/Dinistro commented:

I fear that this will cause more problems than benefits for now. If we want to push this, this will need an RFC and buy in from all parties that work with debug locations on LLVM dialect. This includes flang, CIR, and multiple downstream users.

Currently, this is a partial migration but even the existing upstream utilities will break this. Among these utilities is for example the inliner, which produces callsite locations. Therefore, all users of the debug locations would now need to deal with even more possible formats, which is not necessarily desired. 

https://github.com/llvm/llvm-project/pull/186146