[Mlir-commits] [mlir] [MLIR][LLVM] Add DILocAttr for debug locations (PR #186146)

[Christian Ulmann]

Dinistro wrote:

> LoopAnnotationAttr hardcodes FusedLoc for startLoc/endLoc. I kept that as a [follow-up ](https://github.com/llvm/llvm-project/issues/186277)to keep this change focused. The export retains FusedLoc handling primarily because of loop annotations, and as a defensive fallback in case any producers construct MLIR with the old encoding without going through ModuleImporter (I think it's possible?).

Yes, there will be folks that produce `FusedLocs` without using the `ModuleImporter`, see Flang, CIR, and others. There will be a transition period where this still needs to be allowed but the end goal should be to restrict this clearly.

So, if we want to push for this, we need to invest into the full migration, as a partial migration will cause problems for all places that work with locations.



https://github.com/llvm/llvm-project/pull/186146