[Mlir-commits] [mlir] [mlir][dataflow] Drop the firstIndex argument of visitNonControlFlowArguments (PR #175210)

[lonely eagle]

================
@@ -215,8 +215,8 @@ class AbstractSparseForwardDataFlowAnalysis : public DataFlowAnalysis {
   /// of loops).
   virtual void visitNonControlFlowArgumentsImpl(
       Operation *op, const RegionSuccessor &successor,
-      ValueRange successorInputs, ArrayRef<AbstractSparseLattice *> argLattices,
-      unsigned firstIndex) = 0;
+      ValueRange nonSuccessorInputs,
+      ArrayRef<AbstractSparseLattice *> nonSuccessorInputLattices) = 0;
----------------
linuxlonelyeagle wrote:

* In the original visitNonControlFlowArguments function, all lattices were passed in, including SuccessorInputLattices. You can see this from the diff. Consequently, we needed the firstIndex parameter to locate the SuccessorInputLattices so we could avoid calling setAllToEntryStates on them, as they are handled by the dataflow framework itself.
* We no longer need firstIndex because of how the two cases are handled: in the first case, we ensure that the lattices passed in are exclusively nonSuccessorInputLattices. In the second case (an entry block whose parentOp is not a RegionBranchOp), firstIndex was never necessary to begin with.

https://github.com/llvm/llvm-project/pull/175210