[Mlir-commits] [mlir] [mlir][dataflow] Drop the firstIndex argument of visitNonControlFlowArguments (PR #175210)

[lonely eagle]

================
@@ -215,8 +215,8 @@ class AbstractSparseForwardDataFlowAnalysis : public DataFlowAnalysis {
   /// of loops).
   virtual void visitNonControlFlowArgumentsImpl(
       Operation *op, const RegionSuccessor &successor,
-      ValueRange successorInputs, ArrayRef<AbstractSparseLattice *> argLattices,
-      unsigned firstIndex) = 0;
+      ValueRange nonSuccessorInputs,
+      ArrayRef<AbstractSparseLattice *> nonSuccessorInputLattices) = 0;
----------------
linuxlonelyeagle wrote:

Apologies, I just noticed this comment. There are actually two distinct cases: one involves only nonSuccessorInputLattices, while the other involves all lattices. When the op is not a RegionBranchOp, we pass in all lattices.You can see https://github.com/llvm/llvm-project/blob/5d5d906bfca388c8c11a5f413aa171c761dd7875/mlir/lib/Analysis/DataFlow/SparseAnalysis.cpp#L189.

https://github.com/llvm/llvm-project/pull/175210