https://github.com/banach-space updated https://github.com/llvm/llvm-project/pull/176586
>From 5d1dcb4eb5618947b4298619358a31f8a6468b83 Mon Sep 17 00:00:00 2001
From: Andrzej Warzynski <andrzej.warzynski at arm.com>
Date: Sat, 17 Jan 2026 18:53:13 +0000
Subject: [PATCH] [mlir][nfc] Fix function definition names post #175880
Make sure that the input argument names for `verifyRanksMatch` in the
function devotion match the declaration.
---
mlir/lib/Dialect/Utils/VerificationUtils.cpp | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/mlir/lib/Dialect/Utils/VerificationUtils.cpp b/mlir/lib/Dialect/Utils/VerificationUtils.cpp
index 9b3bfda42b91a..81f1e590a76ee 100644
--- a/mlir/lib/Dialect/Utils/VerificationUtils.cpp
+++ b/mlir/lib/Dialect/Utils/VerificationUtils.cpp
@@ -21,17 +21,17 @@ LogicalResult mlir::verifyDynamicDimensionCount(Operation *op, ShapedType type,
return success();
}
-LogicalResult mlir::verifyRanksMatch(Operation *op, ShapedType type1,
- ShapedType type2, StringRef name1,
- StringRef name2) {
- if (!type1.hasRank() || !type2.hasRank())
+LogicalResult mlir::verifyRanksMatch(Operation *op, ShapedType lhs,
+ ShapedType rhs, StringRef lhsName,
+ StringRef rhsName) {
+ if (!lhs.hasRank() || !rhs.hasRank())
return success(); // Unranked types are considered compatible
- int64_t rank1 = type1.getRank();
- int64_t rank2 = type2.getRank();
+ int64_t rank1 = lhs.getRank();
+ int64_t rank2 = rhs.getRank();
if (rank1 != rank2) {
return op->emitOpError()
- << name1 << " rank (" << rank1 << ") does not match " << name2
+ << lhsName << " rank (" << rank1 << ") does not match " << rhsName
<< " rank (" << rank2 << ")";
}
return success();