[Mlir-commits] [mlir] [mlir][nfc] Fix function definition names post #175880 (PR #176586)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Sat Jan 17 10:55:36 PST 2026


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Andrzej WarzyƄski (banach-space)

<details>
<summary>Changes</summary>

Make sure that the input argument names for `verifyRanksMatch` in the
function devotion match the declaration.


---
Full diff: https://github.com/llvm/llvm-project/pull/176586.diff


1 Files Affected:

- (modified) mlir/lib/Dialect/Utils/VerificationUtils.cpp (+7-7) 


``````````diff
diff --git a/mlir/lib/Dialect/Utils/VerificationUtils.cpp b/mlir/lib/Dialect/Utils/VerificationUtils.cpp
index 9b3bfda42b91a..d6c117d9c68b5 100644
--- a/mlir/lib/Dialect/Utils/VerificationUtils.cpp
+++ b/mlir/lib/Dialect/Utils/VerificationUtils.cpp
@@ -21,17 +21,17 @@ LogicalResult mlir::verifyDynamicDimensionCount(Operation *op, ShapedType type,
   return success();
 }
 
-LogicalResult mlir::verifyRanksMatch(Operation *op, ShapedType type1,
-                                     ShapedType type2, StringRef name1,
-                                     StringRef name2) {
-  if (!type1.hasRank() || !type2.hasRank())
+LogicalResult mlir::verifyRanksMatch(Operation *op, ShapedType lhs,
+                                     ShapedType rhs, StringRef lhsName,
+                                     StringRef rhsNane) {
+  if (!lhs.hasRank() || !rhs.hasRank())
     return success(); // Unranked types are considered compatible
 
-  int64_t rank1 = type1.getRank();
-  int64_t rank2 = type2.getRank();
+  int64_t rank1 = lhs.getRank();
+  int64_t rank2 = rhs.getRank();
   if (rank1 != rank2) {
     return op->emitOpError()
-           << name1 << " rank (" << rank1 << ") does not match " << name2
+           << lhsName << " rank (" << rank1 << ") does not match " << rhsNane
            << " rank (" << rank2 << ")";
   }
   return success();

``````````

</details>


https://github.com/llvm/llvm-project/pull/176586


More information about the Mlir-commits mailing list