[Mlir-commits] [mlir] [MLIR][Transform] Add hoist_extract_to_argument transformation (PR #175004)

[Rolf Morel]

rolfmorel wrote:

Thanks for that, Evyatar.

While @rengolin indeed argues against this transformation being a canonicalization rewrite (pattern), in MLIR we can have rewrite patterns that are not part of a canonicalization rewrite pattern set (quite the mouthful, that). These patterns are there to be gathered together to create your own pass or to use with `transform.apply_patterns` in transform-dialect "schedules." Have a look at this PR for an example of introducing a new transformation as a rewrite pattern, while exposing it via a transform op and without putting the pattern into a canonicalization set: https://github.com/llvm/llvm-project/pull/110514

I haven't checked the pass you mention in detail, though it sounds like another optional transformation. One that shouldn't run concurrently with this transformation (which would be possible if the implementing rewrite patterns where to be part of the same set) or sequentially for that matter, as they would undo each other. Though as usage of that pass and your rewrite pattern will be optional in people's pipelines/schedules, that's okay. It is good to enable different paths for different users.

https://github.com/llvm/llvm-project/pull/175004