[Mlir-commits] [mlir] [MLIR][Transform] Add hoist_extract_to_argument transformation (PR #175004)

[Rolf Morel]

https://github.com/rolfmorel commented:

Hi @evyatar-reif -- thanks for working on this!

Before going over the code in more detail, a general question:
 
_Have you considered exposing this transform as a pattern rewrite_ (and expose the pattern rewrite via a `transform.apply_patterns.*` op)?

One major difference is that patterns can be easily applied to each matching op in a subtree. On the other hand, the advantage your transform op has is that you can match and filter before applying this specific hoist.

Given that the transformation has a canonicalization flavour to it, do you expect anyone will want to selectively apply the transform only to some `linalg.generic`s (rather than, e.g., always all `linalg.generic`s in a function)?

https://github.com/llvm/llvm-project/pull/175004