[Mlir-commits] [mlir] [mlir][Shape] Fix Yoda condition in OutlineShapeComputation (PR #174146)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-shape

Author: Nick Kreeger (nkreeger)

<details>
<summary>Changes</summary>

Change `nullptr != inpDefOp` to `inpDefOp != nullptr` for better readability and consistency with LLVM coding standards.

---
Full diff: https://github.com/llvm/llvm-project/pull/174146.diff


1 Files Affected:

- (modified) mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp (+1-1) 


``````````diff
diff --git a/mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp b/mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp
index b6367977b2b9d..650a2396576fd 100644
--- a/mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp
+++ b/mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp
@@ -290,7 +290,7 @@ void OutlineShapeComputationPass::getClusterFromValue(
       cluster.insert(op);
       for (Value inp : op->getOperands()) {
         Operation *inpDefOp = inp.getDefiningOp();
-        if (nullptr != inpDefOp && visited.insert(inpDefOp).second)
+        if (inpDefOp != nullptr && visited.insert(inpDefOp).second)
           queue.push(inpDefOp);
       }
     }

``````````

</details>


https://github.com/llvm/llvm-project/pull/174146