[Mlir-commits] [mlir] [mlir][Shape] Fix Yoda condition in OutlineShapeComputation (PR #174146)

Nick Kreeger llvmlistbot at llvm.org
Thu Jan 1 07:14:27 PST 2026


https://github.com/nkreeger created https://github.com/llvm/llvm-project/pull/174146

Change `nullptr != inpDefOp` to `inpDefOp != nullptr` for better readability and consistency with LLVM coding standards.

>From 4723e29bb3f3cc93fa7b6d5afb277bb1d97f6a05 Mon Sep 17 00:00:00 2001
From: Nick Kreeger <nick.kreeger at gmail.com>
Date: Thu, 1 Jan 2026 09:13:49 -0600
Subject: [PATCH] [mlir][Shape] Fix Yoda condition in OutlineShapeComputation

Change `nullptr != inpDefOp` to `inpDefOp != nullptr` for better readability and consistency with LLVM coding standards.
---
 mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp b/mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp
index b6367977b2b9d..650a2396576fd 100644
--- a/mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp
+++ b/mlir/lib/Dialect/Shape/Transforms/OutlineShapeComputation.cpp
@@ -290,7 +290,7 @@ void OutlineShapeComputationPass::getClusterFromValue(
       cluster.insert(op);
       for (Value inp : op->getOperands()) {
         Operation *inpDefOp = inp.getDefiningOp();
-        if (nullptr != inpDefOp && visited.insert(inpDefOp).second)
+        if (inpDefOp != nullptr && visited.insert(inpDefOp).second)
           queue.push(inpDefOp);
       }
     }



More information about the Mlir-commits mailing list