[Mlir-commits] [mlir] [mlir][vector] Add multi_reduction_rank_reducing_unrolling (PR #182301)

[Erick Ochoa Lopez]

amd-eochoalo wrote:

> ApplyLowerMultiReductionPatternsOp -> ApplyMultiReductionPatternsOp. This is an umbrella Op rather than just "lowering" (provided that we are OK with the notation that "unrolling" != "lowering").

I have already removed this and replaced this with inlining the three functions. But I will add it again and have the benefits set accordingly to preserve that lowering to Arith Ops only happen for 2D multi-reduction https://github.com/llvm/llvm-project/pull/182332 .

> By "previous functionality", do you mean making sure that the lowering to Arith Ops only happens for 2D multi-reduction?

Yes. Nothing else.

https://github.com/llvm/llvm-project/pull/182301