[Mlir-commits] [mlir] [mlir][vector] Add multi_reduction_rank_reducing_unrolling (PR #182301)

[Andrzej Warzyński]

banach-space wrote:

Hey @amd-eochoalo , I think that we are aligned. Rather than me commenting on every of your points, let me wait for patches - it will be easier with code diffs. All in all it sounds like the right direction.

Here are 3 specific suggestions from me:
* `ApplyLowerMultiReductionPatternsOp` -> `ApplyMultiReductionPatternsOp`. This is an umbrella Op rather than just "lowering" (provided that we are OK with the notation that "unrolling" != "lowering").
* https://github.com/llvm/llvm-project/pull/183721
* `TwoDimMultiReductionToElementWise` + `TwoDimMultiReductionToElementWise` -> `LowerMultiReductionToArithOps`.

> Update the PR description here to state how to achieve previous functionality (setting PatternBenefits correctly)

By "previous functionality", do you mean making sure that the lowering to Arith Ops only happens for 2D multi-reduction? Is there anything else?

https://github.com/llvm/llvm-project/pull/182301