[Mlir-commits] [mlir] [mlir] Improve dialect conversion failure diagnostics (PR #182729)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 3472 tests passed
* 414 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### MLIR
<details>
<summary>MLIR.Transforms/test-legalizer.mlir</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe -allow-unregistered-dialect -split-input-file -test-legalize-patterns="allow-pattern-rollback=1" -verify-diagnostics C:\_work\llvm-project\llvm-project\mlir\test\Transforms\test-legalizer.mlir | c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe C:\_work\llvm-project\llvm-project\mlir\test\Transforms\test-legalizer.mlir
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\mlir-opt.exe' -allow-unregistered-dialect -split-input-file -test-legalize-patterns=allow-pattern-rollback=1 -verify-diagnostics 'C:\_work\llvm-project\llvm-project\mlir\test\Transforms\test-legalizer.mlir'
# .---command stderr------------
# | C:\_work\llvm-project\llvm-project\mlir\test\Transforms\test-legalizer.mlir:228:15: error: unexpected error: failed to legalize operation 'test.illegal_op_f' that was explicitly marked illegal; operands (), results ('i32'); no conversion pattern matched
# |     %result = "test.illegal_op_f"() : () -> (i32)
# |               ^
# | C:\_work\llvm-project\llvm-project\mlir\test\Transforms\test-legalizer.mlir:227:8: error: expected error "failed to legalize operation 'test.illegal_op_f'; operands (), results ('i32'); no conversion pattern matched" was not produced
# |     // expected-error at +1 {{failed to legalize operation 'test.illegal_op_f'; operands (), results ('i32'); no conversion pattern matched}}
# |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# `-----------------------------
# error: command failed with exit status: 1
# executed command: 'c:\_work\llvm-project\llvm-project\build\bin\filecheck.exe' 'C:\_work\llvm-project\llvm-project\mlir\test\Transforms\test-legalizer.mlir'
# note: command had no output on stdout or stderr

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/182729