[Mlir-commits] [mlir] [mlir] Improve dialect conversion failure diagnostics (PR #182729)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Sun Feb 22 02:00:49 PST 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- mlir/lib/Transforms/Utils/DialectConversion.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index dda33918c..1aedb0718 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -3339,9 +3339,9 @@ LogicalResult OperationConverter::convert(Operation *op,
bool isRecursiveLegalization) {
const ConversionConfig &config = rewriter.getConfig();
auto emitFailedToLegalizeDiag = [&](bool wasExplicitlyIllegal) {
- InFlightDiagnostic diag =
- op->emitError() << "failed to legalize operation '" << op->getName()
- << "'";
+ InFlightDiagnostic diag = op->emitError()
+ << "failed to legalize operation '"
+ << op->getName() << "'";
if (wasExplicitlyIllegal)
diag << " that was explicitly marked illegal";
``````````
</details>
https://github.com/llvm/llvm-project/pull/182729
More information about the Mlir-commits
mailing list