[Mlir-commits] [mlir] [mlir][vector] Add finer grained populate methods for multi_reduction (NFC). (PR #180750)

[Andrzej Warzyński]

https://github.com/banach-space commented:

I am happy with the direction, thank for splitting the original PR!

It would be very helpful if you could review https://github.com/llvm/llvm-project/blob/20d3aa944fb5cdbeb7e855fcd0800abd6d4a7842/mlir/test/Dialect/Vector/vector-multi-reduction-lowering.mlir and label every test with the corresponding pattern/`populate` that it is exercising. Ideally, every test could be linked to a particular `populate` that you have created and labelled accordingly. Would you be able to take a look?

Minor comments inline.

https://github.com/llvm/llvm-project/pull/180750