[Mlir-commits] [mlir] [mlir][vector] Add finer grained populate methods for multi_reduction (NFC). (PR #180750)

Andrzej WarzyƄski llvmlistbot at llvm.org
Tue Feb 10 08:32:24 PST 2026


================
@@ -525,6 +548,15 @@ void mlir::vector::populateVectorMultiReductionLoweringPatterns(
                                                     benefit);
 }
 
+void mlir::vector::populateVectorMultiReductionLoweringPatterns(
----------------
banach-space wrote:

Please update the comment for this method. No need to list all the patterns if that's now covered by comments for:
* populateVectorMultiReductionTransformationPatterns
* populateVectorMultiReductionFlatteningPatterns
* populateVectorMultiReductionUnrollingPatterns

I would also add this question in comments: 
> Do we still need this?

IMO "no" and we should establish a deprecation path.

https://github.com/llvm/llvm-project/pull/180750


More information about the Mlir-commits mailing list