[Mlir-commits] [flang] [mlir] [MLIR][LLVM] Enable strict property assembly format (PR #217277)

[Mehdi Amini]

================
@@ -1396,7 +1417,8 @@ def LLVM_MaskedStoreOp : LLVM_ZeroResultIntrOp<"masked.store"> {
                    LLVM_VectorOf<I1>:$mask, I32Attr:$alignment,
                    UnitAttr:$nontemporal);
   let builders = [LLVM_VoidResultTypeOpBuilder, LLVM_ZeroResultOpBuilder];
-  let assemblyFormat = "$value `,` $data `,` $mask attr-dict `:` "
+  let assemblyFormat = "$value `,` $data `,` $mask `alignment` `=` "
+    "$alignment (`nontemporal` $nontemporal^)? attr-dict `:` "
----------------
joker-eph wrote:

Good point. The adjacent optional groups could not parse the second clause when the first was absent because the comma was tied to the first optional. I used the new separator-aware `oilist<,>` where the clauses are independently optional, so commas are emitted only between present clauses. For masked intrinsics, I instead parenthesized the operands and explicitly comma-delimited the following clauses.


https://github.com/llvm/llvm-project/pull/217277