[Mlir-commits] [flang] [mlir] [MLIR][LLVM] Enable strict property assembly format (PR #217277)

[Krzysztof Drewniak]

================
@@ -1396,7 +1417,8 @@ def LLVM_MaskedStoreOp : LLVM_ZeroResultIntrOp<"masked.store"> {
                    LLVM_VectorOf<I1>:$mask, I32Attr:$alignment,
                    UnitAttr:$nontemporal);
   let builders = [LLVM_VoidResultTypeOpBuilder, LLVM_ZeroResultOpBuilder];
-  let assemblyFormat = "$value `,` $data `,` $mask attr-dict `:` "
+  let assemblyFormat = "$value `,` $data `,` $mask `alignment` `=` "
+    "$alignment (`nontemporal` $nontemporal^)? attr-dict `:` "
----------------
krzysz00 wrote:

No, that doesn't quite work

Because
```
... (`,` `keyword1` = $keyword1^)? (`,` `keyword2` `=` $keyword2^)?
```
will fail to parse `..., keyword2 = 42`  because it'll see the comma and start expecting `keyword1` after it

https://github.com/llvm/llvm-project/pull/217277