[Mlir-commits] [mlir] [MLIR] control-flow-sink: don't sink non-pure ops with affine-valid results (PR #218216)

[llvmlistbot at llvm.org]

https://github.com/PragmaTwice commented:

I feel that this fix breaks the abstraction of MLIR. It introduces tight coupling between concrete affine concepts and generic control flow pass, which is not quite MLIR-style. I think we should investigate the issue deeply and figure out a more elegant way if possible.

https://github.com/llvm/llvm-project/pull/218216