[Mlir-commits] [mlir] [mlir] Make emitWarning/emitRemark to use OpWithFlags (PR #217804)

lonely eagle llvmlistbot at llvm.org
Thu Aug 20 19:32:47 PDT 2026


https://github.com/linuxlonelyeagle created https://github.com/llvm/llvm-project/pull/217804

When multiple remarks are emitted on a region op, the output contains significant redundancy. To address this, this PR updates `emitWarning` and `emitRemark` to use `OpWithFlags(this, OpPrintingFlags().skipRegions())`.

>From f5b8f0888c02a5c8a9d2e9423740b5d96cd952ad Mon Sep 17 00:00:00 2001
From: linuxlonelyeagle <2020382038 at qq.com>
Date: Fri, 21 Aug 2026 02:27:45 +0000
Subject: [PATCH] make emitWarning/emitRemark use OpWithFlags.

---
 mlir/lib/IR/Operation.cpp | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/mlir/lib/IR/Operation.cpp b/mlir/lib/IR/Operation.cpp
index b7227d0802ea8..937333b30e14c 100644
--- a/mlir/lib/IR/Operation.cpp
+++ b/mlir/lib/IR/Operation.cpp
@@ -276,7 +276,9 @@ InFlightDiagnostic Operation::emitError(const Twine &message) {
 InFlightDiagnostic Operation::emitWarning(const Twine &message) {
   InFlightDiagnostic diag = mlir::emitWarning(getLoc(), message);
   if (getContext()->shouldPrintOpOnDiagnostic())
-    diag.attachNote(getLoc()) << "see current operation: " << *this;
+    diag.attachNote(getLoc())
+        << "see current operation: "
+        << OpWithFlags(this, OpPrintingFlags().skipRegions());
   return diag;
 }
 
@@ -285,7 +287,9 @@ InFlightDiagnostic Operation::emitWarning(const Twine &message) {
 InFlightDiagnostic Operation::emitRemark(const Twine &message) {
   InFlightDiagnostic diag = mlir::emitRemark(getLoc(), message);
   if (getContext()->shouldPrintOpOnDiagnostic())
-    diag.attachNote(getLoc()) << "see current operation: " << *this;
+    diag.attachNote(getLoc())
+        << "see current operation: "
+        << OpWithFlags(this, OpPrintingFlags().skipRegions());
   return diag;
 }
 



More information about the Mlir-commits mailing list