[Mlir-commits] [clang] [flang] [llvm] [mlir] [IR] Use persistent metadata IDs for pass snapshots (PR #216838)

[llvmlistbot at llvm.org]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- clang/lib/CodeGen/BackendUtil.cpp clang/tools/cir-translate/cir-translate.cpp clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp clang/tools/clang-import-test/clang-import-test.cpp flang/include/flang/Optimizer/CodeGen/CodeGen.h flang/lib/Frontend/FrontendActions.cpp llvm/include/llvm/AsmParser/LLParser.h llvm/include/llvm/AsmParser/Parser.h llvm/include/llvm/CodeGen/MachineModuleSlotTracker.h llvm/include/llvm/IR/IRPrintingPasses.h llvm/include/llvm/IR/Metadata.h llvm/include/llvm/IR/Module.h llvm/include/llvm/IR/ModuleSlotTracker.h llvm/include/llvm/IRPrinter/IRPrintingPasses.h llvm/lib/AsmParser/LLParser.cpp llvm/lib/AsmParser/Parser.cpp llvm/lib/CodeGen/MIRParser/MIParser.cpp llvm/lib/CodeGen/MIRParser/MIRParser.cpp llvm/lib/CodeGen/MIRPrinter.cpp llvm/lib/CodeGen/MachineBasicBlock.cpp llvm/lib/CodeGen/MachineModuleSlotTracker.cpp llvm/lib/CodeGen/MachineOperand.cpp llvm/lib/IR/AsmWriter.cpp llvm/lib/IR/Core.cpp llvm/lib/IR/IRPrintingPasses.cpp llvm/lib/IR/LLVMContextImpl.cpp llvm/lib/IR/LLVMContextImpl.h llvm/lib/IR/Metadata.cpp llvm/lib/IR/MetadataImpl.h llvm/lib/IR/SSAContext.cpp llvm/lib/IRPrinter/IRPrintingPasses.cpp llvm/lib/Passes/StandardInstrumentations.cpp llvm/lib/Target/DirectX/DXILPrettyPrinter.cpp llvm/tools/llvm-dis/llvm-dis.cpp llvm/tools/llvm-extract/llvm-extract.cpp llvm/tools/llvm-link/llvm-link.cpp llvm/tools/llvm-reduce/ReducerWorkItem.cpp llvm/tools/llvm-split/llvm-split.cpp llvm/tools/llvm-stress/llvm-stress.cpp llvm/tools/opt/NewPMDriver.cpp llvm/tools/opt/optdriver.cpp llvm/tools/verify-uselistorder/verify-uselistorder.cpp llvm/unittests/IR/AsmWriterTest.cpp llvm/unittests/IR/MetadataTest.cpp llvm/unittests/IR/ModuleTest.cpp llvm/unittests/MIR/MachineMetadata.cpp mlir/lib/Target/LLVMIR/ConvertToLLVMIR.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Passes/StandardInstrumentations.cpp b/llvm/lib/Passes/StandardInstrumentations.cpp
index 5b788926b..6f79f1b17 100644
--- a/llvm/lib/Passes/StandardInstrumentations.cpp
+++ b/llvm/lib/Passes/StandardInstrumentations.cpp
@@ -327,12 +327,12 @@ void unwrapAndPrint(raw_ostream &OS, IRUnitRef IR) {
 
 // Return true when this is a pass for which changes should be ignored
 bool isIgnored(StringRef PassID) {
-  return isSpecialPass(
-      PassID,
-      {"PassManager", "PassAdaptor", "AnalysisManagerProxy",
-       "DevirtSCCRepeatedPass", "ModuleInlinerWrapperPass", "VerifierPass",
-       "PrintModulePass", "PrintMIRPass", "PrintMIRPreparePass",
-       "RequireAnalysisPass", "InvalidateAnalysisPass"});
+  return isSpecialPass(PassID,
+                       {"PassManager", "PassAdaptor", "AnalysisManagerProxy",
+                        "DevirtSCCRepeatedPass", "ModuleInlinerWrapperPass",
+                        "VerifierPass", "PrintModulePass", "PrintMIRPass",
+                        "PrintMIRPreparePass", "RequireAnalysisPass",
+                        "InvalidateAnalysisPass"});
 }
 
 std::string makeHTMLReady(StringRef SR) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/216838