[Mlir-commits] [flang] [mlir] [MLIR][OpenACC] Enable strict property assembly format (PR #217298)

[Andrzej Warzyński]

banach-space wrote:

Hey @joker-eph , thanks for working on this. Unfortunately, this has broken a number of ClangIR tests `-DCLANG_ENABLE_CIR=On`):
```bash
  Clang :: CIR/CodeGenOpenACC/cache.c
  Clang :: CIR/CodeGenOpenACC/combined-copy.c
  Clang :: CIR/CodeGenOpenACC/combined-copy.cpp
  Clang :: CIR/CodeGenOpenACC/combined-copyin-copyout-create.c
  Clang :: CIR/CodeGenOpenACC/combined-firstprivate-clause.cpp
  Clang :: CIR/CodeGenOpenACC/combined-private-clause.cpp
  Clang :: CIR/CodeGenOpenACC/combined.cpp
  Clang :: CIR/CodeGenOpenACC/compute-copy.c
  Clang :: CIR/CodeGenOpenACC/compute-copy.cpp
  Clang :: CIR/CodeGenOpenACC/compute-copyin-copyout-create.c
  Clang :: CIR/CodeGenOpenACC/compute-firstprivate-clause-templates.cpp
  Clang :: CIR/CodeGenOpenACC/compute-firstprivate-clause.c
  Clang :: CIR/CodeGenOpenACC/compute-firstprivate-clause.cpp
  Clang :: CIR/CodeGenOpenACC/compute-private-clause-templates.cpp
  Clang :: CIR/CodeGenOpenACC/compute-private-clause.c
  Clang :: CIR/CodeGenOpenACC/compute-private-clause.cpp
  Clang :: CIR/CodeGenOpenACC/data-copy-copyin-copyout-create.c
  Clang :: CIR/CodeGenOpenACC/data.c
  Clang :: CIR/CodeGenOpenACC/declare-copy.cpp
  Clang :: CIR/CodeGenOpenACC/declare-copyin.cpp
  Clang :: CIR/CodeGenOpenACC/declare-copyout.cpp
  Clang :: CIR/CodeGenOpenACC/declare-create.cpp
  Clang :: CIR/CodeGenOpenACC/declare-deviceptr.cpp
  Clang :: CIR/CodeGenOpenACC/declare-deviceresident.cpp
  Clang :: CIR/CodeGenOpenACC/declare-link.cpp
  Clang :: CIR/CodeGenOpenACC/declare-present.cpp
  Clang :: CIR/CodeGenOpenACC/enter-data.c
  Clang :: CIR/CodeGenOpenACC/exit-data.c
  Clang :: CIR/CodeGenOpenACC/host_data.c
  Clang :: CIR/CodeGenOpenACC/init.c
  Clang :: CIR/CodeGenOpenACC/kernels.c
  Clang :: CIR/CodeGenOpenACC/loop-private-clause.cpp
  Clang :: CIR/CodeGenOpenACC/loop.cpp
  Clang :: CIR/CodeGenOpenACC/parallel.c
  Clang :: CIR/CodeGenOpenACC/serial.c
  Clang :: CIR/CodeGenOpenACC/set.c
  Clang :: CIR/CodeGenOpenACC/shutdown.c
  Clang :: CIR/CodeGenOpenACC/update.c
  Clang :: CIR/IR/openacc.cir
```

Could you update those tests as well? Thank you :)

https://github.com/llvm/llvm-project/pull/217298