[Mlir-commits] [mlir] [mlir] Fix copy paste typo in convertFromAttribute (PR #192484)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Thu Apr 16 09:49:48 PDT 2026


================
@@ -103,7 +103,7 @@ mlir::convertFromAttribute(bool &storage, Attribute attr,
   auto valueAttr = dyn_cast<BoolAttr>(attr);
   if (!valueAttr)
     return emitError()
-           << "expected string property to come from string attribute";
+           << "expected BoolAttr for key `value`";
----------------
janssen-v wrote:

I followed what I assumed was the convention from the other `convertFromAttribute` overloads. Also thought it to be a bit strange since it's not a dict-key lookup for a specific "Value".

I suppose it somewhat fits the `valueAttr.getValue()` method called afterwards, although that might be a post-hoc rationalization.

https://github.com/llvm/llvm-project/pull/192484


More information about the Mlir-commits mailing list