[Mlir-commits] [mlir] [mlir] Fix copy paste typo in convertFromAttribute (PR #192484)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Vincent (janssen-v)

<details>
<summary>Changes</summary>

It seems that the bool overload for `convertFromAttribute` has a failure message incorrectly copied over from the string overload's implementation.

---
Full diff: https://github.com/llvm/llvm-project/pull/192484.diff


1 Files Affected:

- (modified) mlir/lib/IR/ODSSupport.cpp (+1-1) 


``````````diff
diff --git a/mlir/lib/IR/ODSSupport.cpp b/mlir/lib/IR/ODSSupport.cpp
index f2665d24efda6..95d8fff9f23c7 100644
--- a/mlir/lib/IR/ODSSupport.cpp
+++ b/mlir/lib/IR/ODSSupport.cpp
@@ -103,7 +103,7 @@ mlir::convertFromAttribute(bool &storage, Attribute attr,
   auto valueAttr = dyn_cast<BoolAttr>(attr);
   if (!valueAttr)
     return emitError()
-           << "expected string property to come from string attribute";
+           << "expected BoolAttr for key `value`";
   storage = valueAttr.getValue();
   return success();
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/192484