[Mlir-commits] [flang] [mlir] [MLIR][OpenMP] Improve omp.map.info verification (PR #132066)

[Sergio Afonso]

================
@@ -1751,14 +1745,9 @@ static LogicalResult verifyMapClause(Operation *op, OperandRange mapVars) {
 
         to ? updateToVars.insert(updateVar) : updateFromVars.insert(updateVar);
       }
-
-      if (mapInfoOp.getMapperId() &&
-          !SymbolTable::lookupNearestSymbolFrom<omp::DeclareMapperOp>(
-              mapInfoOp, mapInfoOp.getMapperIdAttr())) {
-        return emitError(op->getLoc(), "invalid mapper id");
-      }
     } else if (!isa<DeclareMapperInfoOp>(op)) {
-      emitError(op->getLoc(), "map argument is not a map entry operation");
+      return emitError(op->getLoc(),
+                       "map argument is not a map entry operation");
     }
----------------
skatrak wrote:

Can you elaborate on your suggestion? This is an 'else if', so we still need to evaluate the previous condition before we can check this one, so we can't hoist this out of the loop if I'm not wrong.

https://github.com/llvm/llvm-project/pull/132066