[Mlir-commits] [flang] [mlir] [MLIR][OpenMP] Improve omp.map.info verification (PR #132066)

Kareem Ergawy llvmlistbot at llvm.org
Thu Mar 20 03:10:23 PDT 2025


================
@@ -1751,14 +1745,9 @@ static LogicalResult verifyMapClause(Operation *op, OperandRange mapVars) {
 
         to ? updateToVars.insert(updateVar) : updateFromVars.insert(updateVar);
       }
-
-      if (mapInfoOp.getMapperId() &&
-          !SymbolTable::lookupNearestSymbolFrom<omp::DeclareMapperOp>(
-              mapInfoOp, mapInfoOp.getMapperIdAttr())) {
-        return emitError(op->getLoc(), "invalid mapper id");
-      }
     } else if (!isa<DeclareMapperInfoOp>(op)) {
-      emitError(op->getLoc(), "map argument is not a map entry operation");
+      return emitError(op->getLoc(),
+                       "map argument is not a map entry operation");
     }
----------------
ergawy wrote:

Can we flip this to be an early return while we are it?

https://github.com/llvm/llvm-project/pull/132066


More information about the Mlir-commits mailing list