[Mlir-commits] [mlir] [MLIR][Bufferization] Retire `enforce-aliasing-invariants` (PR #130929)

[Matthias Springer]

matthias-springer wrote:

`enforce-aliasing-invariants=true` is the default case. `enforce-aliasing-invariants=false` can cause incorrect bufferization.

`enforce-aliasing-invariants` was added before `copy-before-write`. When I added `copy-before-write`, I should have removed `enforce-aliasing-invariants`. There's no reason to have both. If you look at the diff, you see that `enforce-aliasing-invariants` and `copy-before-write` are checked in the same place.

IREE is probably the only project that uses `enforce-aliasing-invariants=false` (I doubt that anybody else even knows about this flag, but I can post in the PSA/Deprecation section.) and you use it together with `copy-before-write=true`, so removing this flag should be a no-op and resolve the issue with one of the reverts that you are carrying on your most recent LLVM integrate.


https://github.com/llvm/llvm-project/pull/130929