[Mlir-commits] [mlir] [MLIR][Bufferization] Retire `enforce-aliasing-invariants` (PR #130929)

[llvmlistbot at llvm.org]

https://github.com/MaheshRavishankar requested changes to this pull request.

The comment here is 

```
Note: Deactivating this flag can lead to incorrect bufferization results
when used incorrectly. This flag is useful with
`AlwaysCopyAnalysisState` which bufferizes all writing tensor
OpOperands out-of-place.
```

It is not clear what "used" incorrectly is. The existing default is for this to be `true`. I feel like this might uncover other bugs in bufferization that isnt being caught by upstream tests. There is definitely an correctness issue here, but this might be too big a hammer. Do we want to do a PSA before hand cause this can be a breaking change and I am fraid about the coverage upstream. 

Also what will happen if `copyBeforeWrite` is set to `true`.

https://github.com/llvm/llvm-project/pull/130929